----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/#review104679 -----------------------------------------------------------
src/docker/docker.cpp (line 433) <https://reviews.apache.org/r/39388/#comment162930> I think there are two problems here to address: - --net is not always set to host, and if it's not it's causing problem as LIBPROCESS_IP takes precedence and also causes framework to not be able to connect - docker code here in src/docker/docker.cpp is meant to be an abstraction to run docker, which we use to run executors and docker tasks. It shouldn't really have logic like this embedded especialy when this is not the desire effect for all docker containers we ever launch from Mesos. And really this problem and setting has to be two cases 1) We run a executor in the docker container 2) --net is host. We need to specifically solve this outside of the docker abstraction. - Timothy Chen On Oct. 17, 2015, 11:18 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39388/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2015, 11:18 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-3740 > https://issues.apache.org/jira/browse/MESOS-3740 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/docker/docker.cpp 56d63dc75637c9f89a239af371f476a85a570696 > src/tests/containerizer/docker_containerizer_tests.cpp > 4bb65afd0ee61cafef68e064a697fdce65d60058 > > Diff: https://reviews.apache.org/r/39388/diff/ > > > Testing > ------- > > Added `DockerContainerizerTest.ROOT_DOCKER_LaunchWithLibprocessIP` test which > fails without the changes made to `src/docker/docker.cpp`. > > > Thanks, > > Michael Park > >
