-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39886/#review104893
-----------------------------------------------------------


Great start. I agree with AlexR that the hierarchical DRF use of roles is 
important enough to mention at the beginning alongside reservations.


docs/roles.md (lines 31 - 32)
<https://reviews.apache.org/r/39886/#comment163162>

    As an administrator, you can set `--acls` to declare which framework 
principals can register as which roles.



docs/roles.md (lines 52 - 53)
<https://reviews.apache.org/r/39886/#comment163157>

    Unless the slave is started with `--default_role="foo"`, in which case all 
resources on that slave are initially reserved for the `foo` role.



docs/roles.md (line 56)
<https://reviews.apache.org/r/39886/#comment163159>

    Also note that you cannot create a persistent volume on unreserved 
resources (those with the `*` role). You must first reserve the disk resource 
and then create the volume.



docs/roles.md (line 61)
<https://reviews.apache.org/r/39886/#comment163160>

    I would call this out at the beginning too, since reservations and the 
hierarchical allocation strategy are the two primary functions of roles in 
Mesos (assuming the default allocator).



docs/roles.md (lines 64 - 65)
<https://reviews.apache.org/r/39886/#comment163161>

    Also worth mentioning `--weights` here since that affects the current/fair 
share calculation.


- Adam B


On Nov. 2, 2015, 5:51 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39886/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 5:51 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3819
>     https://issues.apache.org/jira/browse/MESOS-3819
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also removed a redundant (and arguably slightly wrong) assertion about the
> status of static reservations.
> 
> 
> Diffs
> -----
> 
>   docs/attributes-resources.md f712d094f14426515dabde45f98d6c1ae36c3447 
>   docs/configuration.md e66013ad0b951049df645ff90907f19ae8081cc2 
>   docs/home.md af886257348f24cfeecfc726255d8d45d68af2db 
>   docs/reservation.md 69bde760ece59c68b04a903026b5903e2091ceb0 
>   docs/roles.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39886/diff/
> 
> 
> Testing
> -------
> 
> Previewed with the support/site Docker container.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to