> On Nov. 3, 2015, 8:10 p.m., Vinod Kone wrote:
> > would this only test libevent and skip libev? if yes, we can't do this.
> 
> Jojy Varghese wrote:
>     Would it help to add libev also? I was trying to make this look like the 
> jenkins mesos builds. Console logs there show :
>     ``` echo CMD ./bootstrap '&&' ./configure --verbose --enable-libevent 
> --enable-ssl && ...```

the jenkins "mesos" build is a parameterized build, where one of the parameters 
is the configuration options. the config options we test are
"--enable-libevent --enable-ssl" and "" (empty string which tests libev).

unfortunately, the review bot doesn't support these parameters yet. review bot 
doesn't even run inside docker like the "mesos" build. so it just tests one 
platform (ubuntu) and the default parameters. it would be great if we can fix 
the review bot to do the same things as "mesos". feel free to create a ticket. 
i'll be happy to shepherd.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review104969
-----------------------------------------------------------


On Nov. 3, 2015, 7:42 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 7:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Cody Maloney.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> SSL based tests are not currently verified on reviewbot. This change should 
> enable those tests to be run.
> 
> 
> Diffs
> -----
> 
>   support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 
> 
> Diff: https://reviews.apache.org/r/39914/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to