> On Nov. 2, 2015, 4:11 p.m., Vinod Kone wrote:
> > What's the plan for slave to agent rename in the logs? Having just the 
> > allocator output agent when the rest of the code base outputs slave will be 
> > confusing IMO.
> 
> Alexander Rukletsov wrote:
>     I think we change as we go. I was introducing new log messages and 
> decided not to use a deprecated term "slave", but rather change whole 
> allocator output for consistency.

After the second though, I think it's OK to be consistent in the allocator but 
not with the master. An allocator can be a module, which means allocator logs 
may differ drastically from master logs. Does it make sense?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39860/#review104722
-----------------------------------------------------------


On Nov. 2, 2015, 3:19 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39860/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 3:19 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39860/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to