----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39016/#review105212 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 243) <https://reviews.apache.org/r/39016/#comment163652> This is a c++ idiom for the case of insertion. Please see effective STL, Item 24 by Scott Meyers. - Jojy Varghese On Nov. 4, 2015, 11:46 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39016/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 11:46 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > RegistryClient refactor: refactored lambdas as per review comments. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp > e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c > > Diff: https://reviews.apache.org/r/39016/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Jojy Varghese > >
