-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39873/#review105344
-----------------------------------------------------------

Ship it!


Thanks for reducing jagedness, would love to see the bigger comment paragraphs 
wrap at 70 for readability, but up to you. FWIW I've followed up on the clang 
format thread that prompted the 70 character removal to add some stylistic 
suggestions around comment formatting.

- Ben Mahler


On Nov. 5, 2015, 6:04 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39873/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 6:04 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2864
>     https://issues.apache.org/jira/browse/MESOS-2864
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master now doesn't change the latest state of a task if it has already 
> terminated. But it still updates the status update state and uuid.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp cbae27e7a4059a72bc69e152ec8adaf4ef725965 
> 
> Diff: https://reviews.apache.org/r/39873/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Ran the "RecoverCompletedExecutor" test 100 times as it was failing most of 
> the time without this fix.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to