> On Nov. 5, 2015, 11:22 p.m., Guangya Liu wrote:
> > include/mesos/authorizer/authorizer.proto, line 28
> > <https://reviews.apache.org/r/39985/diff/1/?file=1116935#file1116935line28>
> >
> >     We have some discussions want to reduce the comments to 70 chars per 
> > line.

We actually recently changed the style guide to no longer require comments to 
wrap at 70 chars.
Now comments can/should wrap at 80 chars like everything else. We will not do a 
sweeping change.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39985/#review105376
-----------------------------------------------------------


On Nov. 5, 2015, 1:50 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39985/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 1:50 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
>     https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced ACL protobuf definitions for dynamic reservation.
> Note: this review is continued from https://reviews.apache.org/r/37002/
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.proto 
> 86bbb45f9d91b4098a262e3e50a793f3bb39497e 
> 
> Diff: https://reviews.apache.org/r/39985/diff/
> 
> 
> Testing
> -------
> 
> This is the first in a chain of 5 patches. `make check` was used to test at 
> the end of the chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to