----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40011/#review105410 -----------------------------------------------------------
Ship it! Thanks so much Alex for fixing this! Please make sure you run a distcheck whenever you touch the build-env in any patches and then state so the "testing done" field. - Till Toenshoff On Nov. 6, 2015, 11:07 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40011/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 11:07 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This is not a full standartization of Makefile format, however, it is a step > towards consistency. This patch focuses mainly on the order of files and > corrects obvious issues. These are guidelines behind the change: > > - Files in the same folder should appear in lexicographical order. > - Subfolders should appear in lexicographical order either after files or > mixed with them (depending on the current consensus in the file). > - Though tabs are preferred, spaces are not replaced if they are current > consensus in the file or current section. > > > Diffs > ----- > > src/Makefile.am f0715386732b93936de6c8524957c6a6726fe9df > > Diff: https://reviews.apache.org/r/40011/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
