> On Nov. 6, 2015, 2:48 a.m., Adam B wrote:
> > src/tests/fetcher_tests.cpp, lines 553-554
> > <https://reviews.apache.org/r/39991/diff/1/?file=1116967#file1116967line553>
> >
> >     Where did you pull this TODO from? Should it remain a benh TODO or do 
> > you want to own it?

This is from way before (pre-2014 as I recall), found in and copied from 
pre-existing the code above (line 502). Still valid for any test that uses tar 
in any form.


> On Nov. 6, 2015, 2:48 a.m., Adam B wrote:
> > src/tests/fetcher_tests.cpp, line 548
> > <https://reviews.apache.org/r/39991/diff/1/?file=1116967#file1116967line548>
> >
> >     Unnecessary blank line

Just copied from someone who copied this from someone else. Change everywhere?


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39991/#review105404
-----------------------------------------------------------


On Nov. 5, 2015, 11:46 a.m., Bhuvan Arumugam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39991/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 11:46 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: mesos-2935
>     https://issues.apache.org/jira/browse/mesos-2935
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> fetcher should extract from .tar archive
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 8fb6c83981a141df9c0a8a6f8267230bef64f218 
>   src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 
> 
> Diff: https://reviews.apache.org/r/39991/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>

Reply via email to