> On Nov. 6, 2015, 6:05 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line 
> > 394
> > <https://reviews.apache.org/r/39840/diff/8/?file=1118149#file1118149line394>
> >
> >     We used Shared<> instead of std::shared_ptr in our code base.

dropping based on our discussion


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/#review105451
-----------------------------------------------------------


On Nov. 6, 2015, 6:56 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 6:56 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made reading the stream from the PIPE common.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 29d4d4d6d60ec634efb21b951cf20ff90f6ffed6 
> 
> Diff: https://reviews.apache.org/r/39840/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to