> On Nov. 6, 2015, 7:59 p.m., Greg Mann wrote: > > include/mesos/v1/mesos.proto, lines 1279-1280 > > <https://reviews.apache.org/r/40017/diff/1/?file=1117999#file1117999line1279> > > > > It looks like the equivalent of this comment in > > `include/mesos/mesos.proto` still contains an old TODO that has already > > been removed here. Would it be appropriate to clean up that TODO in this > > review as well?
Hm not sure as it is not the focus of this review (and would even touch a different file). So I would prefere to that in a seperate review. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40017/#review105503 ----------------------------------------------------------- On Nov. 6, 2015, 12:16 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40017/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 12:16 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2851 > https://issues.apache.org/jira/browse/MESOS-2851 > > > Repository: mesos > > > Description > ------- > > Review 37196 added the Docker image type to the old API, this review does the > same for the v1 API. > > > Diffs > ----- > > include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a > > Diff: https://reviews.apache.org/r/40017/diff/ > > > Testing > ------- > > make distcheck > > > Thanks, > > Joerg Schad > >
