----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40001/#review105552 -----------------------------------------------------------
src/tests/containerizer/filesystem_isolator_tests.cpp (line 109) <https://reviews.apache.org/r/40001/#comment164169> In fact, remove 'public' here since non of the methods below are used outside the test. - Jie Yu On Nov. 6, 2015, 10:10 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40001/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 10:10 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Joris Van Remoortere. > > > Bugs: MESOS-3847 > https://issues.apache.org/jira/browse/MESOS-3847 > > > Repository: mesos > > > Description > ------- > > The special cleanup in the non-Stout `TemporaryDirectoryTest` was moved into > `LinuxFilesystemIsolatorTest`. > `LinuxFilesystemIsolatorTest` creates additional mounts as part of its tests. > No other tests require the special cleanup logic to pass. > > > Diffs > ----- > > src/tests/containerizer/filesystem_isolator_tests.cpp > f1ab98a1a9c0cff25c8f9f5d2324384228efcedb > src/tests/utils.hpp d4fc6ac96e0cfd6924304dfa1e9e454a113f46f7 > src/tests/utils.cpp cc3e9e9ce368216cbf3e065c58d3e20919c26671 > > Diff: https://reviews.apache.org/r/40001/diff/ > > > Testing > ------- > > `make check` on OSX. > > `sudo make check` on Centos7. > > > Thanks, > > Joseph Wu > >
