----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40054/#review105603 -----------------------------------------------------------
Bad patch! Reviews applied: [40053] Failed command: ./support/apply-review.sh -n -r 40053 Error: 2015-11-08 07:08:19 URL:https://reviews.apache.org/r/40053/diff/raw/ [3177448/3177448] -> "40053.patch" [1] error: patch failed: 3rdparty/libprocess/include/process/http.hpp:68 error: 3rdparty/libprocess/include/process/http.hpp: patch does not apply error: patch failed: 3rdparty/libprocess/src/http.cpp:31 error: 3rdparty/libprocess/src/http.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Nov. 8, 2015, 7 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40054/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2015, 7 a.m.) > > > Review request for mesos, Bernd Mathiske and Ben Mahler. > > > Bugs: MESOS-3367 > https://issues.apache.org/jira/browse/MESOS-3367 > > > Repository: mesos > > > Description > ------- > > Fix fetch parsing problem for URL with query. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > 0b676f43e8529c6790824c8cf82e21a81d885ef1 > src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 > > Diff: https://reviews.apache.org/r/40054/diff/ > > > Testing > ------- > > # Add `FetcherTest.OSNetUriWithQueryTest` test case. > # @bernd-mesos, @bmahler We could do a quick wround in old code. But I think > add a parsing function for URL maybe better, it also could fix the TODO item. > I think we also could update the code in fetcher to use process::http::URL, > so far I only change the Fetcher::basename function. > > > Thanks, > > haosdent huang > >
