----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39276/#review105821 -----------------------------------------------------------
3rdparty/libprocess/include/process/event.hpp (line 145) <https://reviews.apache.org/r/39276/#comment164490> rename to `response` 3rdparty/libprocess/src/process.cpp (line 189) <https://reviews.apache.org/r/39276/#comment164491> All code related to this go to another patch. 3rdparty/libprocess/src/process.cpp (lines 2334 - 2336) <https://reviews.apache.org/r/39276/#comment164494> if we do move, remove this comment. 3rdparty/libprocess/src/process.cpp (line 2337) <https://reviews.apache.org/r/39276/#comment164489> No pointer + std::move. 3rdparty/libprocess/src/process.cpp (lines 2341 - 2343) <https://reviews.apache.org/r/39276/#comment164496> Reuse similar comments for this code there. 3rdparty/libprocess/src/tests/http_tests.cpp (line 1178) <https://reviews.apache.org/r/39276/#comment164492> to separate patch, change other test and verify this one is actually needed. Also write down that we need to reorder the ProcessBase::visit 3rdparty/libprocess/src/tests/http_tests.cpp (line 1183) <https://reviews.apache.org/r/39276/#comment164507> Remove. 3rdparty/libprocess/src/tests/http_tests.cpp (line 1218) <https://reviews.apache.org/r/39276/#comment164509> Try to reuse requests. - Alexander Rojas On Nov. 10, 2015, 4:58 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39276/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 4:58 a.m.) > > > Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff. > > > Bugs: MESOS-3705 > https://issues.apache.org/jira/browse/MESOS-3705 > > > Repository: mesos > > > Description > ------- > > When using the same socket to send multiple HTTP requests to different > actors. If the actor responsible for handling the first request is stuck > handling another event while a subsequent request can reply immediatly, the > order of the responses is altered violating HTTP Pipelining. > > This patch fixes that problem enforcing that every response is sent in the > order the corresponding request arrived. It also adds a test to reproduce the > issue and verify the fix works. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/event.hpp > 16ddbd77afa6efdf6bad201aa497ee102aa863ae > 3rdparty/libprocess/src/process.cpp > a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 > 3rdparty/libprocess/src/tests/http_tests.cpp > 7eb4ef187b2cb358c370d0381db65b8e18668bab > > Diff: https://reviews.apache.org/r/39276/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
