----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40230/#review106242 -----------------------------------------------------------
Ship it! Looks good, just a minor suggestion below which I'll take care of when committing. Also, probably we want to be clear in the description that the main motivation for this is to ensure we're testing that pipelining is correct across actors (not so much that we detect the subtle bug you mentioned). 3rdparty/libprocess/src/tests/http_tests.cpp (line 742) <https://reviews.apache.org/r/40230/#comment165006> Looks like we need a comment here to mention why we're using 2 http servers. Just something simple like: // We use 2 'Http' Processes to ensure that pipelining // is respected across Processes in libprocess. - Ben Mahler On Nov. 12, 2015, 2:10 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40230/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 2:10 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-3705 > https://issues.apache.org/jira/browse/MESOS-3705 > > > Repository: mesos > > > Description > ------- > > Updates the HTTP pipelining test in order to verify that pipelining works > across multiple actors. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/http_tests.cpp > 7eb4ef187b2cb358c370d0381db65b8e18668bab > > Diff: https://reviews.apache.org/r/40230/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
