----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40234/#review106257 -----------------------------------------------------------
docs/configuration.md (line 1049) <https://reviews.apache.org/r/40234/#comment165017> I agree we should capitalize "Docker", but if we're going to do this, can we do it consistently, both here and in flags.cpp? - Neil Conway On Nov. 12, 2015, 4:08 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40234/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 4:08 p.m.) > > > Review request for mesos, Till Toenshoff and Timothy Chen. > > > Bugs: MESOS-3905 > https://issues.apache.org/jira/browse/MESOS-3905 > > > Repository: mesos > > > Description > ------- > > Added descriptions of new Docker-related flags to configuration.md. See > slave/flags.cpp: > > add(&Flags::docker_auth_server, > "docker_auth_server", > "Docker authentication server", > "auth.docker.io"); > > add(&Flags::docker_auth_server_port, > "docker_auth_server_port", > "Docker authentication server port", > "443"); > add(&Flags::docker_puller_timeout_secs, > "docker_puller_timeout", > "Timeout value in seconds for pulling images from Docker registry", > "60"); > > add(&Flags::docker_registry, > "docker_registry", > "Default Docker image registry server host", > "registry-1.docker.io"); > > add(&Flags::docker_registry_port, > "docker_registry_port", > "Default Docker registry server port", > "443"); > > > Diffs > ----- > > docs/configuration.md 2049256419f1eb5eb6520548f2019594afa9a97b > > Diff: https://reviews.apache.org/r/40234/diff/ > > > Testing > ------- > > Looked at configuration.md in a web browser and a markdown renderer. > > > Thanks, > > Bernd Mathiske > >