-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40250/#review106480
-----------------------------------------------------------

Ship it!



src/Makefile.am (line 197)
<https://reviews.apache.org/r/40250/#comment165194>

    why the distinction between public and private? looks like they are always 
used together.



src/Makefile.am (lines 232 - 250)
<https://reviews.apache.org/r/40250/#comment165193>

    kill the white space while you are at it?


- Vinod Kone


On Nov. 12, 2015, 7:26 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40250/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 7:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Consolidated all the CXX protobuf generation rules in src/Makefile.am.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
> 
> Diff: https://reviews.apache.org/r/40250/diff/
> 
> 
> Testing
> -------
> 
> ./configure
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to