----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39800/#review106495 -----------------------------------------------------------
Patch looks great! Reviews applied: [39799, 39800] All tests passed. - Mesos ReviewBot On Nov. 13, 2015, 5:38 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39800/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 5:38 p.m.) > > > Review request for mesos, Bernd Mathiske, haosdent huang, and Timothy Chen. > > > Bugs: MESOS-3605 > https://issues.apache.org/jira/browse/MESOS-3605 > > > Repository: mesos > > > Description > ------- > > - Swallow WARN log messages unless the command failed or we could > not parse the output. > - Make the actual du output parsing more reliable by not using > human-readable format, scanning all the output lines, and > tokenizing rather than splitting the output lines. > > > Diffs > ----- > > src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba > src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 > > Diff: https://reviews.apache.org/r/39800/diff/ > > > Testing > ------- > > make check. Manual testing with a framework that uses the fetcher with HDFS > urls. > > > Thanks, > > James Peach > >
