----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/#review106518 -----------------------------------------------------------
src/master/master.cpp (lines 2737 - 2738) <https://reviews.apache.org/r/39987/#comment165223> This temp variable does not seem to be necessary. Can you just do: ``` LOG(INFO) << "Authorizing principal '" << (principal.isSome() ? principal.get() : "ANY") << "' to reserve resources"; ``` src/master/master.cpp (line 2754) <https://reviews.apache.org/r/39987/#comment165224> We don't use tailing period for log messages. Please do a sweep to fix all of them. src/master/master.cpp (lines 2782 - 2789) <https://reviews.apache.org/r/39987/#comment165221> I think we should assume validation::operation::validate(unreserve) has already been called. Maybe use a CHECK here is more appropriate. ``` CHECK(isDynamicallyReserved(resource)) << ... ``` src/master/master.cpp (lines 2794 - 2799) <https://reviews.apache.org/r/39987/#comment165222> Can you just stringify(unreserve.resources()) below when calling LOG(INFO)? src/master/master.cpp (lines 2802 - 2804) <https://reviews.apache.org/r/39987/#comment165225> Ditto above. No need for the 'principalString' temp variable. - Jie Yu On Nov. 13, 2015, 4:30 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39987/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 4:30 a.m.) > > > Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff. > > > Bugs: MESOS-3062 > https://issues.apache.org/jira/browse/MESOS-3062 > > > Repository: mesos > > > Description > ------- > > Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve. > Note: this review is continued from https://reviews.apache.org/r/37125/ > > > Diffs > ----- > > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 > > Diff: https://reviews.apache.org/r/39987/diff/ > > > Testing > ------- > > This is the third in a chain of 5 patches. `make check` was used to test > after all patches were applied. > > > Thanks, > > Greg Mann > >
