----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40371/#review106768 -----------------------------------------------------------
src/cli/execute.cpp (line 116) <https://reviews.apache.org/r/40371/#comment165535> I think we should have a default (Mesos perhaps), and also I don't see why we should need to upper case this where every other flag is lower cased. src/cli/execute.cpp (line 421) <https://reviews.apache.org/r/40371/#comment165537> Instead of failing here and checking again in the Framework, how about just putting this check and wanring inside and leave it out here? - Timothy Chen On Nov. 16, 2015, 11:15 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40371/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 11:15 p.m.) > > > Review request for mesos and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Since docker_image option could be used for mesos and docker containerizer, > introduced a new option 'containerizer' to disambiguate the two > containerizers. > > New usage: > mesos-execute --master=127.0.0.1:5050 --command="uname -a" \ > --name=test_docker --docker_image=ubuntu --containerizer=DOCKER > > mesos-execute --master=127.0.0.1:5050 --command="uname -a" \ > --name=test_mesos --docker_image=ubuntu --containerizer=MESOS > > > Diffs > ----- > > src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc > > Diff: https://reviews.apache.org/r/40371/diff/ > > > Testing > ------- > > tested the two containerizer locally with simple commands. > > > Thanks, > > Jojy Varghese > >
