----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37266/#review106832 -----------------------------------------------------------
support/cpplint.py (line 2966) <https://reviews.apache.org/r/37266/#comment165646> The regex for the return type fails to match e.g. template instantiations; this should match but currently does not unique_ptr<int, decltype(&free)> makeInt() { The regex for the function name fails to match identifiers containing literal `::` so it misses non-inline definitions of member functions. - Benjamin Bannier On Nov. 17, 2015, 10:33 a.m., Jose Guilherme Vanz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37266/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 10:33 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-2578 > https://issues.apache.org/jira/browse/MESOS-2578 > > > Repository: mesos > > > Description > ------- > > As requested in the issue MESOS-2578 the style checker now > verifies { on newline for class and methods declarations. > > This commit contains the files changed in the mesos project > > > Diffs > ----- > > src/authentication/cram_md5/authenticator.cpp > 6a84e9184df837cd90ac7485b88ae7f47e12537b > src/docker/executor.hpp fa13b6e9905051eef27d3a51b75a5c86fdad0dd7 > src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 > src/logging/logging.cpp fb798670d9ac79c75ad39905614fbfe1ea25fba6 > src/python/native/src/mesos/native/module.hpp > 31da47b474d017e910d90e41ad15f2163b07dc89 > src/slave/containerizer/isolators/network/port_mapping.cpp > 88c0cbc61f3f97b084cc3b3fae8999b07d4aa1c7 > src/tests/containerizer/docker_containerizer_tests.cpp > 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 > src/tests/containerizer/rootfs.hpp 55dd4964cfb1ca0e5f7b7616ccc6d5ad2be135d7 > src/tests/environment.hpp 9cf14bcc8f7d386f6aa26b686d3f953c969aaf63 > support/cpplint.py bfd3390002a680b07aa3fcf785279ad19625294b > support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 > > Diff: https://reviews.apache.org/r/37266/diff/ > > > Testing > ------- > > > Thanks, > > Jose Guilherme Vanz > >
