-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38234/#review106919
-----------------------------------------------------------



src/tests/containerizer/cgroups_tests.cpp (lines 560 - 568)
<https://reviews.apache.org/r/38234/#comment165721>

    instead of asserting, it would be better if we can disable the test 
automatically if we detect that swap is enabled.
    
    for example, we can change the test name to ROOT_CGROUPS_OOM_Listen
    
    and in environment.cpp, disable the test if 'OOM' token is present in the 
test name and swap is enabled.
    
    also, does the swap issue not affect the balloon framewok test?


- Vinod Kone


On Sept. 9, 2015, 9:33 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38234/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2015, 9:33 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: mesos-2918
>     https://issues.apache.org/jira/browse/mesos-2918
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Check if swap is enabled before running memory pressure related tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> 75a3bc0009c037dc18ce319db2eb44630f083e8c 
> 
> Diff: https://reviews.apache.org/r/38234/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Reply via email to