----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40146/#review106936 -----------------------------------------------------------
Ship it! Looks good. Just a few nits (newlines) here and there to stay consistent with the style guide. 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp <https://reviews.apache.org/r/40146/#comment165739> We want to keep the double-space here. 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 278) <https://reviews.apache.org/r/40146/#comment165741> We want a double-space here. 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp <https://reviews.apache.org/r/40146/#comment165740> We want to keep the double-space here. - Joseph Wu On Nov. 10, 2015, 12:14 p.m., Steve Butler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40146/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 12:14 p.m.) > > > Review request for mesos and Alex Clemmer. > > > Bugs: MESOS-3881 > https://issues.apache.org/jira/browse/MESOS-3881 > > > Repository: mesos > > > Description > ------- > > Windows: Unifies POSIX and Windows PSTree implementations > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 741639a942971e48e2dac42db238d423e61cac21 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pstree.hpp > fd0192ca021eb0211b293eb2f4e521d588aff04f > 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp > 9baa2fbfafa310517b70d54f190167f1cccbad6a > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pstree.hpp > f75a77fc58db09fadf80409f506852e48a7df7c4 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 1a7037d64afeedc340258c92067e95d1d3caa027 > > Diff: https://reviews.apache.org/r/40146/diff/ > > > Testing > ------- > > > Thanks, > > Steve Butler > >
