-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37540/#review106926
-----------------------------------------------------------



src/linux/perf.cpp (line 514)
<https://reviews.apache.org/r/37540/#comment165731>

    s/Gcc/GCC/



src/linux/perf.cpp (line 516)
<https://reviews.apache.org/r/37540/#comment165732>

    s/use/Use/
    s/gcc/GCC/



src/linux/perf.cpp (line 590)
<https://reviews.apache.org/r/37540/#comment165742>

    Lets add a comment to PerfEvent::read() (the interface) about what the 
semantics are for simultaneous read.



src/linux/perf.cpp (line 593)
<https://reviews.apache.org/r/37540/#comment165744>

    i think you need a .onDiscard() handler here.



src/linux/perf.cpp (line 597)
<https://reviews.apache.org/r/37540/#comment165745>

    so if one of the fds in the map is ready `_read()` is called? what happens 
when another fd in the map  becomes ready?



src/linux/perf.cpp (line 602)
<https://reviews.apache.org/r/37540/#comment165746>

    if io:poll() fails on an fd, you terminate the process but if it gets 
discarded (who discards it?), the process continues?



src/linux/perf.cpp (line 871)
<https://reviews.apache.org/r/37540/#comment165734>

    instead of two colons in the error message, do
    
    return Error("Failed to create PerfEvent for cgroup '" + cgroup + "': " + 
event.error());


- Vinod Kone


On Sept. 30, 2015, 12:12 a.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37540/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 12:12 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-2769
>     https://issues.apache.org/jira/browse/MESOS-2769
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Abstract Linux kernel perf event API and provide API to collect schedule 
> events.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.hpp d10968ca670eb516bae08385fd0ddde8e8ad83b5 
>   src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a 
>   src/tests/containerizer/perf_tests.cpp 
> ed5212ee31b8aa47339b8b8fab184bbdf85be82a 
> 
> Diff: https://reviews.apache.org/r/37540/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Reply via email to