> On Nov. 18, 2015, 6:21 p.m., Vinod Kone wrote:
> > support/hooks/post-rewrite, line 33
> > <https://reviews.apache.org/r/40445/diff/1/?file=1130933#file1130933line33>
> >
> >     instead of calling this script directly, i would recommend calling it 
> > from mesos-style.py. this way users and tools (review bot) can run just one 
> > script to test compliance.

We do already call two scripts from the hooks ATM (one to wrap `cpplint.py`, 
and one to check for properly split commits across libraries). Looking at 
`mesos-style.py`, its logic is pretty much tied to just running `cpplint` and 
parsing its output -- do you really mean we should rewrite all of that?

Note that users can always manually run the hooks.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review107061
-----------------------------------------------------------


On Nov. 18, 2015, 4:05 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2015, 4:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Marco Massenzio.
> 
> 
> Bugs: MESOS-3581
>     https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -----
> 
>   support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
>   support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 
>   support/mesos-license.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> -------
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to