----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40398/#review107208 -----------------------------------------------------------
Do we have this added to the design doc (or Jira ticket), it would be nice to capture some more details about the target functionality. include/mesos/master/allocator.hpp (line 120) <https://reviews.apache.org/r/40398/#comment166216> I assume string is for role? if yes: a) this is non-trivial to guess... b) why do we need it? isn't that included in QuotaInfo already? - Joerg Schad On Nov. 17, 2015, 8:54 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40398/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 8:54 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3873 > https://issues.apache.org/jira/browse/MESOS-3873 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 > src/master/allocator/mesos/allocator.hpp > d2d32af227d66c4030becd4cd64b907a70d25f49 > src/master/allocator/mesos/hierarchical.hpp > 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 > src/master/allocator/mesos/hierarchical.cpp > f2e3b639f210eb06c70584ee7294609d9fd978ad > src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 > > Diff: https://reviews.apache.org/r/40398/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
