----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40291/#review107223 -----------------------------------------------------------
Ship it! We might want to clarify that if you have a multi-line statement that is immediately followed by a closing brace, you don't need a newline before the brace. docs/c++-style-guide.md (line 114) <https://reviews.apache.org/r/40291/#comment166241> Why the <> in <Try ...;> ? docs/c++-style-guide.md (line 118) <https://reviews.apache.org/r/40291/#comment166242> The point is that the for loop condition should be defined over multiple lines, right? - Neil Conway On Nov. 16, 2015, 5:32 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40291/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 5:32 p.m.) > > > Review request for mesos, Bernd Mathiske and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Added the stye guideline for blank line after line-wrapping. > > > Diffs > ----- > > docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad > > Diff: https://reviews.apache.org/r/40291/diff/ > > > Testing > ------- > > viewed rendered doc. > > > Thanks, > > Joerg Schad > >
