-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40507/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 3:38 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Bugs: MESOS-3753
    https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
-------

Normally, the containerizer would be cleaned and deallocated by one of the 
helper methods in `MesosTest` or in `test::Cluster`.  However, in this case, 
the containerizer is allocated via `MesosContainerizer::create` and then passed 
to `MockSlave`.  `MockSlave` does not clean up the containerizer upon 
destruction.

Note: `MockSlave` normally takes a reference to a containerizer allocated on 
the stack, hence why it does not deallocate.


Diffs
-----

  src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 

Diff: https://reviews.apache.org/r/40507/diff/


Testing (updated)
-------

`make check`

Note: If you **only** add `delete containerizer.get();` to the end of the test, 
the test suite will output:
```
[----------] Global test environment tear-down
../../src/tests/environment.cpp:488: Failure
Failed
Tests completed with child processes remaining:
-+- 29543 /path/to/mesos/build/src/.libs/mesos-tests
 --- 29558 /bin/sh /path/to/mesos/build/src/mesos-containerizer launch 
--command={"shell":true,"value":"\/path\/to\/mesos\/build\/src\/mesos-executor"}
 --commands={"commands":[]} --directory=/tmp --help=false --pipe_read=13 
--pipe_write=16 --user=test
```


Thanks,

Joseph Wu

Reply via email to