----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40418/#review107398 -----------------------------------------------------------
Ship it! src/uri/fetcher.cpp (line 40) <https://reviews.apache.org/r/40418/#comment166492> include pluging.error() in the message. src/uri/fetchers/curl.cpp (line 74) <https://reviews.apache.org/r/40418/#comment166494> include mkdir.error() in the message src/uri/fetchers/curl.cpp (line 146) <https://reviews.apache.org/r/40418/#comment166498> s/Parsing/Parse/ src/uri/fetchers/curl.cpp (line 154) <https://reviews.apache.org/r/40418/#comment166500> s/Invalid/Unexpected/ - Vinod Kone On Nov. 18, 2015, 11:25 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40418/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 11:25 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-3924 > https://issues.apache.org/jira/browse/MESOS-3924 > > > Repository: mesos > > > Description > ------- > > Added curl based URI fetcher plugin. > > > Diffs > ----- > > src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 > src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 > src/tests/uri_fetcher_tests.cpp PRE-CREATION > src/uri/fetcher.cpp PRE-CREATION > src/uri/fetchers/curl.hpp PRE-CREATION > src/uri/fetchers/curl.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40418/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >