----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40400/#review107510 -----------------------------------------------------------
Ship it! src/tests/registrar_tests.cpp (line 685) <https://reviews.apache.org/r/40400/#comment166659> I don't think the `once` is necessary. src/tests/registrar_tests.cpp (line 687) <https://reviews.apache.org/r/40400/#comment166661> Let's use full words. `Alternate`, or we could enumerate them. src/tests/registrar_tests.cpp (lines 691 - 693) <https://reviews.apache.org/r/40400/#comment166667> Since `Resources` has this as an implicit conversion, why do you need the explicit static cast here? (and below) src/tests/registrar_tests.cpp (lines 722 - 723) <https://reviews.apache.org/r/40400/#comment166670> I think there is an implicit constructor that takes a repeated resource proto. src/tests/registrar_tests.cpp (line 745) <https://reviews.apache.org/r/40400/#comment166672> We can just reference the `guarantee` here for the implicit constructor. - Joris Van Remoortere On Nov. 22, 2015, 5:02 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40400/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2015, 5:02 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3165 > https://issues.apache.org/jira/browse/MESOS-3165 > > > Repository: mesos > > > Description > ------- > > Follow up of https://reviews.apache.org/r/39983 > > > Diffs > ----- > > src/tests/registrar_tests.cpp f4ed01e9f37f8291921b67f7fb2f54839812c8b1 > > Diff: https://reviews.apache.org/r/40400/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
