----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40424/#review107595 -----------------------------------------------------------
Bad patch! Reviews applied: [40424] Failed command: ./support/apply-review.sh -n -r 40424 Error: 2015-11-23 15:19:51 URL:https://reviews.apache.org/r/40424/diff/raw/ [1841/1841] -> "40424.patch" [1] Successfully applied: Enhance the existing HTTP endpoint /roles In this ticket, we will enhance the existing HTTP endpoint to query roles as outlined in the dynamic role design Doc. Review: https://reviews.apache.org/r/40424 Checking 1 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo src/master/http.cpp:1350: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2] src/master/http.cpp:1369: Lines should be <= 80 characters long [whitespace/line_length] [2] Total errors found: 2 Failed to commit patch - Mesos ReviewBot On Nov. 23, 2015, 2:55 p.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40424/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 2:55 p.m.) > > > Review request for mesos, Adam B, Guangya Liu, and Qian Zhang. > > > Bugs: MESOS-3791 > https://issues.apache.org/jira/browse/MESOS-3791 > > > Repository: mesos > > > Description > ------- > > In this ticket, we will enhance the existing > HTTP endpoint to query roles as outlined in > the dynamic role design Doc. > > > Diffs > ----- > > src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 > > Diff: https://reviews.apache.org/r/40424/diff/ > > > Testing > ------- > > Test results: > $ curl http://127.0.0.1:5050/roles > {"roles":[{"frameworks":[],"name":"cc","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"bb","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0},{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} > > $ curl http://127.0.0.1:5050/roles?roleName=aa > {"roles":[{"frameworks":[],"name":"aa","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} > > > $ curl http://127.0.0.1:5050/roles?roleName=dd > The specified role [dd] does not exist! > > > Thanks, > > Yong Qiao Wang > >
