> On Nov. 24, 2015, 10:25 p.m., Guangya Liu wrote: > > Seems the rebase caused some problem for your patch, some files are lost.
There's only file for this patch; if still issue, please ping me online. > On Nov. 24, 2015, 10:25 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4460 > > <https://reviews.apache.org/r/40379/diff/3/?file=1138604#file1138604line4460> > > > > s/allocations/usage slack? Used comments in `mesos.proto` - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107786 ----------------------------------------------------------- On Nov. 24, 2015, 7:02 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40379/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 7:02 p.m.) > > > Review request for mesos and Guangya Liu. > > > Bugs: MESOS-3930 > https://issues.apache.org/jira/browse/MESOS-3930 > > > Repository: mesos > > > Description > ------- > > In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK > for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps > to update `RevocableInfo::type` for Oversubscription. > > > Diffs > ----- > > src/slave/slave.cpp 9055f2a > > Diff: https://reviews.apache.org/r/40379/diff/ > > > Testing > ------- > > make (make check is on-going) > > > Thanks, > > Klaus Ma > >
