> On Nov. 24, 2015, 3:58 p.m., Neil Conway wrote: > > src/tests/fault_tolerance_tests.cpp, line 720 > > <https://reviews.apache.org/r/39320/diff/4/?file=1138902#file1138902line720> > > > > I'd remove this comment -- various other places use the same pattern. > > I'd also remove the newline after CreateMasterFlags(), to match the other > > places we use this pattern. > > Alexander Rukletsov wrote: > I think we are not consistent, e.g. see > https://github.com/apache/mesos/blob/master/src/tests/master_maintenance_tests.cpp#L1293
Sure. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review107793 ----------------------------------------------------------- On Nov. 24, 2015, 3:57 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39320/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 3:57 p.m.) > > > Review request for mesos, Benjamin Bannier, Bernd Mathiske, Neil Conway, and > Till Toenshoff. > > > Bugs: MESOS-3732 > https://issues.apache.org/jira/browse/MESOS-3732 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > 3bbd6cbf6b101415c90991c48f00f33a5aff5590 > > Diff: https://reviews.apache.org/r/39320/diff/ > > > Testing > ------- > > make check > > The run time for the `FaultToleranceTest.FrameworkReregister` test has > reduced from more than `1s` to less than `100ms`. > Before: > ``` > [ RUN ] FaultToleranceTest.FrameworkReregister > [ OK ] FaultToleranceTest.FrameworkReregister (1018 ms) > ``` > After: > ``` > [ RUN ] FaultToleranceTest.FrameworkReregister > [ OK ] FaultToleranceTest.FrameworkReregister (49 ms) > ``` > > > Thanks, > > Alexander Rukletsov > >
