----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40524/#review107808 -----------------------------------------------------------
include/mesos/resources.hpp (lines 53 - 54) <https://reviews.apache.org/r/40524/#comment167090> This isn't allowed in a header. (We don't want the namespace(s) to be polluted with unnecessary aliases.) include/mesos/v1/resources.hpp (lines 53 - 54) <https://reviews.apache.org/r/40524/#comment167091> Not allowed for the same reason above. - Joseph Wu On Nov. 23, 2015, 9:42 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40524/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 9:42 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, > and Klaus Ma. > > > Bugs: MESOS-3955 > https://issues.apache.org/jira/browse/MESOS-3955 > > > Repository: mesos > > > Description > ------- > > Enabled resources.cpp and resources.hpp use std::string > > > Diffs > ----- > > include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d > include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c > src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c > src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428 > > Diff: https://reviews.apache.org/r/40524/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
