----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40114/#review107866 -----------------------------------------------------------
Ship it! Ship It! - Alex Clemmer On Nov. 24, 2015, 11:04 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40114/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 11:04 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Added Windows & Posix defines for several parameter list used in future.hpp. > Provided a new parameter list for VC2015. > Move the existing parameter list into posix.hpp. > > The change has been due to: > > 1. VS 2015 won't support C++14 result_of SFINAE until Update 2, so > result_of must be replaced with decltype(invoke). > 2. VS 2015 won't support C++14 std::function SFINAE until Update 2, so > converting _Deferred to std::function must be done by explicitly > calling _Deferred's conversion function. > 3. The Standard (C++11 through 17) does not require bind's function call > operator to SFINAE, and VS 2015's doesn't. is_bind_expression can be > used to manually reroute bind expressions to the 1-arg overload, where > (conveniently) the argument will be ignored if necessary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 3916150691e9a0880b8b826734fa74bd33d18cfd > 3rdparty/libprocess/include/process/posix/future.hpp PRE-CREATION > 3rdparty/libprocess/include/process/windows/future.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40114/diff/ > > > Testing > ------- > > OSX make check, Windows 10 make, Ubuntu 15.1 make check > > > Thanks, > > Daniel Pravat > >
