This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 25, 2015, 9:54 a.m.)

Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.


Move `using mesos::fetcher::FetcherInfo` into `mesos::internal::test` in 

Bugs: MESOS-3963

Repository: mesos


According to the google code style, the using should be used in internal 
namespace in header files. Grep the header files, only fetcher.hpp deserved a 

> You may use a using-declaration anywhere in a .cc file (including in the 
> global namespace), and in functions, methods, classes, or within internal 
> namespaces in .h files.

>Do not use using-declarations in .h files except in explicitly marked 
>internal-only namespaces, because anything imported into a namespace in a .h 
>file becomes part of the public API exported by that file.

// OK in .cc files.
// Must be in a function, method, internal namespace, or
// class in .h files.
using ::foo::bar;

Diffs (updated)

  src/slave/containerizer/fetcher.hpp 78e7d14 
  src/tests/mesos.hpp a2a76f5 

Diff: https://reviews.apache.org/r/40631/diff/


make && make check


Klaus Ma

Reply via email to