> On Nov. 25, 2015, 2:25 a.m., Guangya Liu wrote: > > src/tests/authentication_tests.cpp, line 311 > > <https://reviews.apache.org/r/40654/diff/1/?file=1138954#file1138954line311> > > > > Not yours but do you mind to update s/Try<PID<Slave> >/Try<PID<Slave>> > > and the following?
Sure -- although I believe that committers would like to see these kinds of cleanups as a separate commit. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40654/#review107899 ----------------------------------------------------------- On Nov. 24, 2015, 4:54 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40654/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 4:54 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Cleaned up usage of `CreateSlaveFlags()` in a test file. > > > Diffs > ----- > > src/tests/authentication_tests.cpp 98a872e8b5c69737e334fd5d4838d988d8aced95 > > Diff: https://reviews.apache.org/r/40654/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
