> On Nov. 25, 2015, 7:06 a.m., Timothy Chen wrote:
> > src/tests/environment.cpp, line 147
> > <https://reviews.apache.org/r/40679/diff/1/?file=1139378#file1139378line147>
> >
> >     Cfs should be CFS_ right?

Currently, the tests are not prefixed with `CFS_` the way the CGROUP, etc. 
tests are. I added a todo to change the name of these tests to match that 
convention, and since there are only two of them perhaps I can just take care 
of that in this review.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/#review107933
-----------------------------------------------------------


On Nov. 25, 2015, 1:05 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40679/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 1:05 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-3964 and MESOS-3978
>     https://issues.apache.org/jira/browse/MESOS-3964
>     https://issues.apache.org/jira/browse/MESOS-3978
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added filtering of CFS cgroup tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 
> 
> Diff: https://reviews.apache.org/r/40679/diff/
> 
> 
> Testing
> -------
> 
> CFS support is disabled by default and must be enabled via a command-line 
> flag. Thus, the test suite should not assume that this feature is present.
> 
> To test, run `sudo make check` on Debian 8 or another linux distribution 
> without CFS cgroup support.
> 
> Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or 
> LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota without this patch, and 
> those tests should be filtered out after this patch. I ran `sudo make check` 
> on Ubuntu 14.04 and the CFS tests ran like normal, and passed.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to