> On Nov. 25, 2015, 11:35 p.m., Joris Van Remoortere wrote:
> > Added
> > ```
> > EXPECT_CALL(sched2, resourceOffers(&framework2, _))
> >   .Times(0);
> > EXPECT_CALL(sched3, resourceOffers(&framework3, _))
> >   .Times(0);
> > ```
> > to resolve The assertion issue opened.
> > 
> > Tested with gtest_shuffle, repeat

I'm afraid this may render the test flaky. At some point, after quota request 
reaches the allocator and offers are rescinded, an allocation for `framework2` 
and `framework3` may happen. In this case, we race with the allocation timeout. 
This is the reason why I haven't introduced this expectations. I think we can 
fix it by either carefully stopping the clock or intercepting `ResourceOffers` 
message. What do you think?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40396/#review108074
-----------------------------------------------------------


On Nov. 24, 2015, 4:29 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40396/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 4:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3985
>     https://issues.apache.org/jira/browse/MESOS-3985
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 330e591f81c7ece7f401042ad159bd6b55881a84 
> 
> Diff: https://reviews.apache.org/r/40396/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to