-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40697/#review108183
-----------------------------------------------------------


Can you translate your test cases into GTest?

- Klaus Ma


On Nov. 26, 2015, 10:18 p.m., Yong Qiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40697/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 10:18 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-3942
>     https://issues.apache.org/jira/browse/MESOS-3942
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enhance endpoint /roles for adding a new role
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b 
>   src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38 
>   src/master/role_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40697/diff/
> 
> 
> Testing
> -------
> 
> $ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
> http://127.0.0.1:5050/roles
> 
> $ curl -d role="{\"name\":\"role1\",\"weight\":2}" -X POST 
> http://127.0.0.1:5050/roles
> Failed to validate set role request string: 
> ('role={"name":"role1","weight":2}')': This role already exist!
> 
> $ curl -X GET http://127.0.0.1:5050/roles/role1
> {"status":[{"infos":{"name":"role1","weight":2.0}}]}
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Reply via email to