----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40754/#review108247 -----------------------------------------------------------
Ship it! Fixed before committing. src/tests/master_quota_tests.cpp (lines 940 - 942) <https://reviews.apache.org/r/40754/#comment167578> Let's clarify that this is the situation we are avoiding. src/tests/master_quota_tests.cpp (line 964) <https://reviews.apache.org/r/40754/#comment167579> Can we settle, and then resume here? I think with Joseph's cleanups we shouldn't exit a test with the clock paused. - Joris Van Remoortere On Nov. 26, 2015, 5:34 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40754/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 5:34 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Fixed flaky test (AvailableResourcesAfterRescinding). > > > Diffs > ----- > > src/tests/master_quota_tests.cpp 15edb27f3ea5d3813c937614aa217ca999fd2481 > > Diff: https://reviews.apache.org/r/40754/diff/ > > > Testing > ------- > > GTEST_FILTER="*AvailableResourcesAfterRescinding*" ./bin/mesos-tests.sh > --gtest_repeat=1000 with `allocation_interval` set to 1ms > > > Thanks, > > Alexander Rukletsov > >
