> On 十一月 27, 2015, 12:54 a.m., Guangya Liu wrote:
> > src/common/resources.cpp, line 779
> > <https://reviews.apache.org/r/40755/diff/1/?file=1147692#file1147692line779>
> >
> >     1) v1 should also be updated
> >     2) Add a unit test for this new type?
> 
> Alexander Rukletsov wrote:
>     Good catch, thanks! Do we have a doc which says when we should update /v1?

Not yet, but I see that the current default policy is always keep v1 and pre-v1 
synced. https://issues.apache.org/jira/browse/MESOS-3510


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40755/#review108176
-----------------------------------------------------------


On 十一月 27, 2015, 2:46 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40755/
> -----------------------------------------------------------
> 
> (Updated 十一月 27, 2015, 2:46 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Michael Park.
> 
> 
> Bugs: MESOS-4020
>     https://issues.apache.org/jira/browse/MESOS-4020
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d 
>   include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c 
>   src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c 
>   src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 
>   src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428 
> 
> Diff: https://reviews.apache.org/r/40755/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to