> On Nov. 27, 2015, 9:53 p.m., Till Toenshoff wrote: > > src/tests/fetcher_cache_tests.cpp, lines 325-326 > > <https://reviews.apache.org/r/40776/diff/1/?file=1148003#file1148003line325> > > > > Let's add a reference to the JIRA describing the issue in more detail > > -- here and also in those other two duplicates of this comment. > > > > ``` > > // Create an uncompressed tar archive (See MESOS-XXXX). > > ```
Done, went with `... (see ...`. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108246 ----------------------------------------------------------- On Nov. 28, 2015, 11:15 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40776/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2015, 11:15 a.m.) > > > Review request for mesos, Bernd Mathiske and Till Toenshoff. > > > Bugs: MESOS-3579 > https://issues.apache.org/jira/browse/MESOS-3579 > > > Repository: mesos > > > Description > ------- > > GNU tar-1.28 and earlier can relatively randomly misidentify > compressed files as uncompressed ones, and will then fail when > unpacking. Avoid compressed tar files in some tests where we know we > directly call the tar system command (in mesos-fetcher in this case). > > > Diffs > ----- > > src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309 > src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a > > Diff: https://reviews.apache.org/r/40776/diff/ > > > Testing > ------- > > `make check` and verified test does not fail in at least 17500 iterations. > > > Thanks, > > Benjamin Bannier > >
