> On Nov. 24, 2015, 1:23 a.m., Timothy Chen wrote:
> > src/tests/containerizer/docker_tests.cpp, line 298
> > <https://reviews.apache.org/r/37703/diff/6/?file=1089376#file1089376line298>
> >
> >     This test failed for me since at the time docker->exec is called the 
> > container isn't running yet.
> >     
> >     Please abstract out the exists() method (probably in 
> > tests/containerizer/docker_test_helper.hpp) in  containerizer_docker_tests 
> > so you can use it here that you wait until the container is running before 
> > you run docker exec.

Are you refer to the `exists` method in 
`src/tests/containerizer/docker_containerizer_tests.cpp`? Because could not use 
it in `src/tests/containerizer/docker_tests.cpp`, I use `AWAIT_READY(status);` 
directly.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review107694
-----------------------------------------------------------


On Oct. 3, 2015, 9:09 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2015, 9:09 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3291
>     https://issues.apache.org/jira/browse/MESOS-3291
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add docker exec command.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f 
>   src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
>   src/tests/containerizer/docker_tests.cpp 
> babc7d8da4ed9d13b14bd69decd7f27fc7dfde89 
> 
> Diff: https://reviews.apache.org/r/37703/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to