-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39780/#review108299
-----------------------------------------------------------



src/tests/oversubscription_tests.cpp (line 106)
<https://reviews.apache.org/r/39780/#comment167698>

    This isn't really too nice, and e.g. cmake does not put build libraries 
into these paths (i.e. what you write will only work with automake).
    
    Like I already pointed out on #40553, you should really lift the level of 
abstraction here, and use a function to get this path.


- Benjamin Bannier


On Nov. 26, 2015, 2:03 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39780/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 2:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-3725
>     https://issues.apache.org/jira/browse/MESOS-3725
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update OversubscriptionTest to not assume dynamic dlopen search.
> 
> 
> Diffs
> -----
> 
>   src/tests/oversubscription_tests.cpp 
> 0d0bf7e0b9a4028ed116e00b56d59b670510c5ce 
> 
> Diff: https://reviews.apache.org/r/39780/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>

Reply via email to