> On Dec. 1, 2015, 1:49 p.m., Alexander Rukletsov wrote: > > I propose to replace the comment in https://reviews.apache.org/r/40818/ > > > > Just curious, how did you spot this? it looks fine in my editor. Also, is > > it something we should add as a commit hook? > > Neil Conway wrote: > Hi Alex -- note that the revised comment in > https://reviews.apache.org/r/40818/ still has non-ASCII characters. > > I noticed the characters when looking at "git log -p" for some unrelated > (now forgotten) purpose. > > I agree this is something we should add as a commit hook. > > Alexander Rukletsov wrote: > You are right — I've updated the patch. I'll also file a JIRA ticket for > adding a hook.
Anyway, I think this patch can be committed, since I do not know what path we will choose for fixing the flaky test. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40799/#review108494 ----------------------------------------------------------- On Nov. 30, 2015, 6:43 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40799/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2015, 6:43 p.m.) > > > Review request for mesos, Alexander Rukletsov and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Removed non-ASCII characters from test case comment. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp 481298361574008b2cf9d213c908deb633393e31 > > Diff: https://reviews.apache.org/r/40799/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
