----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40849/#review108601 -----------------------------------------------------------
Patch looks great! Reviews applied: [40849] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Dec. 2, 2015, 12:58 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40849/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 12:58 a.m.) > > > Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till > Toenshoff. > > > Bugs: MESOS-3586 > https://issues.apache.org/jira/browse/MESOS-3586 > > > Repository: mesos > > > Description > ------- > > The existing tests will check that "low" pressure events occur at least as > often as "medium" pressure events (this is the documented behavior). > However, the order of events and the order in which we process said events is > not guaranteed. When we collect the pressure events via a counter, there may > be some events that are in-flight, and thereby not accounted for in the > counters. > > This patch modifies MemoryPressureMesosTests to wait for memory pressure > events to stop before checking the counts for correctness. > The tests now stop the memory-pressure-triggering task and then wait for all > events to be processed before checking the counters. > > > Diffs > ----- > > src/tests/containerizer/memory_pressure_tests.cpp > e18b971c4df26c9b9c103ca73bdad4fd400d6c02 > > Diff: https://reviews.apache.org/r/40849/diff/ > > > Testing > ------- > > On Debian 8: > `make check` > `sudo bin/mesos-tests.sh --gtest_filter="*MemoryPressure*" --gtest_repeat=-1 > --gtest_break_on_failure` > > ^ Ran the above for a couple minutes (it was previously failing ~1/5 times). > > TODO: Need to run the test on other platforms it is known to be failing on. > i.e. Ubuntu 14, Centos 6, Centos 7, others? > > > Thanks, > > Joseph Wu > >
