----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39288/#review108628 -----------------------------------------------------------
src/master/quota_handler.cpp (lines 156 - 157) <https://reviews.apache.org/r/39288/#comment168082> Let's also add authorization to `Master::QuotaHandler::remove()` src/master/quota_handler.cpp (lines 163 - 165) <https://reviews.apache.org/r/39288/#comment168080> Let's leave a `TODO` for authorization. src/master/quota_handler.cpp (line 249) <https://reviews.apache.org/r/39288/#comment168084> Do you think refactoring `Master::Http::authenticate()` into `Master::authenticateHttp()` is a big deal? - Alexander Rukletsov On Nov. 20, 2015, 10:04 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39288/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 10:04 a.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van > Remoortere, and Till Toenshoff. > > > Bugs: MESOS-3861 > https://issues.apache.org/jira/browse/MESOS-3861 > > > Repository: mesos > > > Description > ------- > > Added authentication of quota requests. > > > Diffs > ----- > > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39288/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
