----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review108637 -----------------------------------------------------------
Ship it! include/mesos/authorizer/authorizer.hpp (lines 136 - 141) <https://reviews.apache.org/r/40346/#comment168090> Let' reformat the comment to avoid jaggedness. Also, let's backtick `request` since it refers to the variable name and remove the artice then. include/mesos/authorizer/authorizer.hpp (line 143) <https://reviews.apache.org/r/40346/#comment168092> Backtick `ACL::SetQuota` Does reformatting avoid jaggedness here? include/mesos/authorizer/authorizer.hpp (line 145) <https://reviews.apache.org/r/40346/#comment168091> s/with/for include/mesos/authorizer/authorizer.hpp (lines 147 - 148) <https://reviews.apache.org/r/40346/#comment168093> Formatting src/tests/mesos.hpp (lines 1245 - 1247) <https://reviews.apache.org/r/40346/#comment168089> Please move this into .cpp (as part of the rebase). - Alexander Rukletsov On Nov. 20, 2015, 10:03 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40346/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 10:03 a.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van > Remoortere, and Till Toenshoff. > > > Bugs: MESOS-3862 > https://issues.apache.org/jira/browse/MESOS-3862 > > > Repository: mesos > > > Description > ------- > > Quota: Implemented authorization of quota requests in the authorizer. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > d667a52f90f970a313580446a5a006cec4b5e25b > src/authorizer/local/authorizer.hpp > 32de102fd588f029882ef2222121ca83a7410c65 > src/authorizer/local/authorizer.cpp > 6d7da87731a438c2180cf91003e09d4aa5a1c773 > src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed > > Diff: https://reviews.apache.org/r/40346/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
