-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40551/#review108846
-----------------------------------------------------------

Ship it!


Fixed in-line.


src/master/allocator/mesos/hierarchical.cpp (line 1026)
<https://reviews.apache.org/r/40551/#comment168309>

    new line.



src/master/allocator/mesos/hierarchical.cpp (lines 1100 - 1101)
<https://reviews.apache.org/r/40551/#comment168310>

    Let's fold these together.



src/master/allocator/mesos/hierarchical.cpp (line 1118)
<https://reviews.apache.org/r/40551/#comment168312>

    `const`?



src/master/allocator/mesos/hierarchical.cpp (line 1134)
<https://reviews.apache.org/r/40551/#comment168315>

    Let's clarify that, in this case, we continue rather than "stop".



src/master/allocator/mesos/hierarchical.cpp (line 1137)
<https://reviews.apache.org/r/40551/#comment168317>

    `are allocated or accounted for`


- Joris Van Remoortere


On Nov. 30, 2015, 3:24 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40551/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 3:24 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota is satisfied in a separate loop over agents. Running total is 
> maintained as an exit criterion for the WDRF allocation stage.
> 
> Precursory version: https://reviews.apache.org/r/39401/
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 31ed62efb5b1a2edb567f43d37559c5914e0665e 
> 
> Diff: https://reviews.apache.org/r/40551/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to